-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js,types): Add menuButtonEllipsis
descriptor
#5090
feat(clerk-js,types): Add menuButtonEllipsis
descriptor
#5090
Conversation
🦋 Changeset detectedLatest commit: 923dbbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we need the additional descriptor.
(optional) I'd suggest naming it something like menuButtonThreeDots
.
I am not a huge fan |
menuButtonMoreOptions
descriptor
…fects-button-for-dropdown-and-other
…fects-button-for-dropdown-and-other
menuButtonMoreOptions
descriptormenuButtonEllipsis
descriptor
This reverts commit 0391fe8.
…n-for-dropdown-and-other' of github.com:clerk/javascript into alexcarpenter/sdk-2050-menubutton-element-affects-button-for-dropdown-and-other
Description
Introduce new
menuButtonEllipsis
descriptor to target<ThreeDotsMenu />
triggers.cl-menuButton cl-button
cl-menuButtonEllipsis cl-menuButton cl-button
Resolves SDK-2050
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change