Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,types): Add menuButtonEllipsis descriptor #5090

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Feb 6, 2025

Description

Introduce new menuButtonEllipsis descriptor to target <ThreeDotsMenu /> triggers.

Screenshot 2025-02-06 at 11 34 14 AM

Screenshot 2025-02-06 at 11 37 41 AM

BEFORE AFTER
cl-menuButton cl-button cl-menuButtonEllipsis cl-menuButton cl-button

Resolves SDK-2050

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: 923dbbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 3:41pm

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we need the additional descriptor.

(optional) I'd suggest naming it something like menuButtonThreeDots.

@alexcarpenter
Copy link
Member Author

I am not a huge fan menuButtonThreeDots or menuButtonEllipsis to be honest. That feels like I am targeting the svg icon inside instead of the button element. Still thinking on naming.

@alexcarpenter alexcarpenter marked this pull request as draft February 6, 2025 19:11
@alexcarpenter alexcarpenter changed the title feat(clerk-js,types): Add menuButtonEllipsis descriptor feat(clerk-js,types): Add menuButtonMoreOptions descriptor Feb 7, 2025
@alexcarpenter alexcarpenter marked this pull request as ready for review February 7, 2025 14:20
@alexcarpenter alexcarpenter changed the title feat(clerk-js,types): Add menuButtonMoreOptions descriptor feat(clerk-js,types): Add menuButtonEllipsis descriptor Feb 7, 2025
This reverts commit 0391fe8.
…n-for-dropdown-and-other' of github.com:clerk/javascript into alexcarpenter/sdk-2050-menubutton-element-affects-button-for-dropdown-and-other
@alexcarpenter alexcarpenter merged commit 767ac85 into main Feb 7, 2025
29 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/sdk-2050-menubutton-element-affects-button-for-dropdown-and-other branch February 7, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants