Skip to content

chore(clerk-js): Prefer popup for v0.dev domain #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Conversation

mwickett
Copy link
Member

@mwickett mwickett commented Jun 13, 2025

Description

Adds v0.dev as a domain that prefer the popup oauth flow.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Improved support for popup flows on additional domains ending with ".v0.dev".

@mwickett mwickett requested review from aeliox, wobsoriano and a team as code owners June 13, 2025 18:59
Copy link

changeset-bot bot commented Jun 13, 2025

🦋 Changeset detected

Latest commit: 5dfcfef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 7:21pm

Copy link
Contributor

coderabbitai bot commented Jun 13, 2025

📝 Walkthrough

Walkthrough

The constant array of origin suffixes used to determine popup preference was updated by adding a new entry, '.v0.dev'. No other logic, control flow, or public API was modified in the file.

Changes

Files Change Summary
packages/clerk-js/src/ui/utils/originPrefersPopup.ts Added '.v0.dev' to the list of popup-preferred origins
.changeset/evil-jobs-boil.md Added patch update note for supporting '.v0.dev' domain in popup OAuth flows

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5535c22 and 5dfcfef.

📒 Files selected for processing (1)
  • .changeset/evil-jobs-boil.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/evil-jobs-boil.md
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Jun 13, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6118

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6118

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6118

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6118

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6118

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6118

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6118

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6118

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6118

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6118

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6118

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6118

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6118

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6118

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6118

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6118

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6118

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6118

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6118

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6118

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6118

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6118

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6118

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6118

commit: 5dfcfef

@panteliselef panteliselef changed the title prefer popup for v0 domain chore(clerk-js): Prefer popup for v0.dev domain Jun 13, 2025
@mwickett mwickett merged commit fa96943 into main Jun 13, 2025
41 checks passed
@mwickett mwickett deleted the mw.add-v0-prefer-popup branch June 13, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants