-
Notifications
You must be signed in to change notification settings - Fork 359
chore(clerk-js, shared): Create experimental PaymentElement #6180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
panteliselef
wants to merge
21
commits into
main
Choose a base branch
from
elef/com-960-dx-guide-introduce-checkout-utilities
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3c59cf7
chore(clerk-js, shared): Create experimental PaymentElement
panteliselef 2d6d48b
mark as experimental
panteliselef cc91f08
add wip changeset
panteliselef 240cca9
Merge branch 'main' into elef/com-960-dx-guide-introduce-checkout-uti…
panteliselef 814e37a
export all experimental apis
panteliselef d038eec
re implement react stripe
panteliselef 9899b0c
cleanup stripe-react.tsx
panteliselef 053b1e6
remove usage of `@stripe/react-stripe-js` from clerk-js
panteliselef dddbb09
bump bundle size of ui common
panteliselef f9f4edb
remove unnecessary state handling
panteliselef ffe90af
decrease stripe-vendors size
panteliselef 860234e
cleanup
panteliselef 2eb7bfb
cleanup 2
panteliselef a645207
add changesets
panteliselef ce930d0
remove wip changeset
panteliselef 2005c75
handle export snapshot tests
panteliselef 493e052
update `waitForStipeElements`
panteliselef 10be49d
rest of sdks
panteliselef 0b407f7
exclude payment elemnent from chrome-extension
panteliselef aee12d0
revert integration test change
panteliselef 41401b1
Merge branch 'main' into elef/com-960-dx-guide-introduce-checkout-uti…
panteliselef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@clerk/chrome-extension': patch | ||
--- | ||
|
||
Refactor re-exports from `@clerk/clerk-react`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
'@clerk/nextjs': minor | ||
'@clerk/clerk-react': minor | ||
'@clerk/shared': minor | ||
--- | ||
|
||
Export experimental hooks and components for PaymentElement | ||
- `__experimental_usePaymentElement` | ||
- `__experimental_PaymentElementProvider` | ||
- `__experimental_PaymentElement` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@clerk/clerk-js': minor | ||
--- | ||
|
||
Remove `@stripe/react-stripe-js` dependency and only allow loading of stripe-js via `Clerk.__internal_loadStripeJs()`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
'@clerk/tanstack-react-start': minor | ||
'@clerk/react-router': minor | ||
'@clerk/remix': minor | ||
--- | ||
|
||
Export experimental hooks and components for PaymentElement | ||
- `__experimental_usePaymentElement` | ||
- `__experimental_PaymentElementProvider` | ||
- `__experimental_PaymentElement` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@clerk/types': minor | ||
--- | ||
|
||
Add `__internal_loadStripeJs` in Clerk interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
export { | ||
APIKeys, | ||
AuthenticateWithRedirectCallback, | ||
ClerkDegraded, | ||
ClerkFailed, | ||
ClerkLoaded, | ||
ClerkLoading, | ||
CreateOrganization, | ||
OrganizationList, | ||
OrganizationProfile, | ||
OrganizationSwitcher, | ||
PricingTable, | ||
Protect, | ||
RedirectToCreateOrganization, | ||
RedirectToOrganizationProfile, | ||
RedirectToSignIn, | ||
RedirectToSignUp, | ||
RedirectToUserProfile, | ||
SignIn, | ||
SignInButton, | ||
SignInWithMetamaskButton, | ||
SignOutButton, | ||
SignUp, | ||
SignUpButton, | ||
SignedIn, | ||
SignedOut, | ||
UserButton, | ||
UserProfile, | ||
Waitlist, | ||
useAuth, | ||
useClerk, | ||
useEmailLink, | ||
useOrganization, | ||
useOrganizationList, | ||
useReverification, | ||
useSession, | ||
useSessionList, | ||
useSignIn, | ||
useSignUp, | ||
useUser, | ||
} from '@clerk/clerk-react'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmilewski do we need these to be set as external ? We are now stop using
react-stripe-js'
and I think onlystripe-js'
loads remote hosted code.Also now don't import
@stripe/stripe-js
directly in the AIOs, but instead we dynamically import it fromClerk.__internal_loadStripeJs()