-
Notifications
You must be signed in to change notification settings - Fork 419
chore(remix): Add deprecation warning for maintenance mode #6744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 84cd67b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughIntroduces a maintenance-mode deprecation notice for the Remix package. On module import, it logs a one-time warning directing users to migrate to @clerk/react-router, with links. Adds a changeset entry for a minor version update and migration guidance. No public APIs changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant App as App (Importer)
participant Remix as packages/remix/src/index.ts
participant Logger as Logger
App->>Remix: import '@clerk/remix'
activate Remix
Remix->>Logger: warnOnce("Remix in maintenance mode... migrate to @clerk/react-router")
note right of Logger: One-time deprecation warning on first import
Remix-->>App: export * from './client'
deactivate Remix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
✨ Finishing Touches
🧪 Generate unit tests
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
.changeset/eleven-timers-clean.md (2)
7-8: Fix markdownlint MD034 (no-bare-urls).Wrap the URLs in angle brackets or convert to link syntax to satisfy markdownlint.
-Migration guide: https://reactrouter.com/upgrading/remix -React Router SDK: https://clerk.com/docs/quickstarts/react-router +Migration guide: <https://reactrouter.com/upgrading/remix> +React Router SDK: <https://clerk.com/docs/quickstarts/react-router>
1-6: Changeset content looks good. Consider whether this warrants patch vs. minor.Since this is a runtime warning with no API change, a patch bump may also be appropriate. If your release policy prefers minor for deprecation messaging, ignore.
packages/remix/src/index.ts (3)
3-15: Gate the deprecation warning to dev/test to avoid production log noise.This runs on every import (server and browser). Suggest gating to dev/test and allowing opt-out via env.
-import { logger } from '@clerk/shared/logger'; - -logger.warnOnce(` +import { logger } from '@clerk/shared/logger'; + +if (process.env.NODE_ENV !== 'production' && process.env.CLERK_SDK_WARNINGS !== 'false') { + logger.warnOnce(` Clerk - DEPRECATION WARNING: @clerk/remix is now in maintenance mode. @clerk/remix will only receive security updates. No new features will be added. Please migrate to @clerk/react-router for continued development and new features: Migration guide: https://reactrouter.com/upgrading/remix React Router SDK: https://clerk.com/docs/quickstarts/react-router -`); + `); +}
5-14: Tune copy to align with official guidance and avoid implying “Remix itself” is in maintenance mode.React Router v7 is positioned as the next major version after Remix v2; the “Wake up, Remix!” post outlines a new (non-React) direction for Remix v3. Suggest clarifying the message to focus on this package’s maintenance status and direct users to the upgrade guide.
-logger.warnOnce(` -Clerk - DEPRECATION WARNING: @clerk/remix is now in maintenance mode. - -@clerk/remix will only receive security updates. No new features will be added. - -Please migrate to @clerk/react-router for continued development and new features: - -Migration guide: https://reactrouter.com/upgrading/remix -React Router SDK: https://clerk.com/docs/quickstarts/react-router -`); +logger.warnOnce(` +Clerk - NOTICE: The @clerk/remix package is now in maintenance mode and will only receive security updates. + +For ongoing feature development, migrate to @clerk/react-router. React Router v7 is the evolution of Remix v2. + +Upgrade guide: https://reactrouter.com/upgrading/remix +Clerk React Router SDK: https://clerk.com/docs/quickstarts/react-router +`);
- Reference: “Upgrading from Remix” (React Router v7 is the next major version after v2). (reactrouter.com)
- Context: “Wake up, Remix!” outlines Remix v3’s direction (not React-dependent). (remix.run)
3-3: Sanity check: confirmlogger.warnOncededupes across both server and client bundles.If warnOnce de-dupes per process only, users may still see one log on server and one in the browser. That’s acceptable, but confirm intent.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.changeset/eleven-timers-clean.md(1 hunks)packages/remix/src/index.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/eleven-timers-clean.md
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/remix/src/index.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/remix/src/index.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/remix/src/index.ts
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/remix/src/index.ts
packages/**/index.{js,ts}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use tree-shaking friendly exports
Files:
packages/remix/src/index.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidanytype - preferunknownwhen type is uncertain, then narrow with type guards
Useinterfacefor object shapes that might be extended
Usetypefor unions, primitives, and computed types
Preferreadonlyproperties for immutable data structures
Useprivatefor internal implementation details
Useprotectedfor inheritance hierarchies
Usepublicexplicitly for clarity in public APIs
Preferreadonlyfor properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertionsfor literal types:as const
Usesatisfiesoperator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noanytypes without justification
Proper error handling with typed errors
Consistent use ofreadonlyfor immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/remix/src/index.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/remix/src/index.ts
**/index.ts
📄 CodeRabbit inference engine (.cursor/rules/react.mdc)
Use index.ts files for clean imports but avoid deep barrel exports
Avoid barrel files (index.ts re-exports) as they can cause circular dependencies
Files:
packages/remix/src/index.ts
🪛 markdownlint-cli2 (0.17.2)
.changeset/eleven-timers-clean.md
7-7: Bare URL used
(MD034, no-bare-urls)
8-8: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)
- GitHub Check: Integration Tests (custom, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Integration Tests (tanstack-react-router, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (quickstart, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (machine, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
- GitHub Check: Unit Tests (22, **)
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Static analysis
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
Description
Adds a deprecation warning to the
@clerk/remixpackage to inform users that it's now in maintenance mode and will only receive security updates. Remix itself is in maintenance mode and only receives security updates.The original Remix authors are working on a new "Remix" package that is not React-based, and may confuse future developers using the
@clerk/remixpackage.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Documentation
Chores