Skip to content

Integrate react compiler into rspack build #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: vincent-and-the-doctor
Choose a base branch
from
Draft

Integrate react compiler into rspack build #7109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/clerk-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,21 @@
"crypto-js": "^4.2.0",
"dequal": "2.0.3",
"input-otp": "1.4.2",
"react-compiler-runtime": "^19.0.0-beta-8a03594-20241020",
"qrcode.react": "4.2.0",
"regenerator-runtime": "0.14.1",
"swr": "2.3.4"
},
"devDependencies": {
"@babel/core": "^7.28.5",
"@babel/plugin-syntax-typescript": "^7.26.0",
"@clerk/testing": "workspace:^",
"@rsdoctor/rspack-plugin": "^0.4.13",
"@rspack/cli": "^1.4.11",
"@rspack/core": "^1.4.11",
"@rspack/plugin-react-refresh": "^1.5.0",
"babel-loader": "^9.2.1",
"babel-plugin-react-compiler": "^19.0.0-beta-9ee70a1-20241017",
"@svgr/webpack": "^6.5.1",
"@types/cloudflare-turnstile": "^0.2.2",
"@types/node": "^22.18.12",
Expand Down
165 changes: 120 additions & 45 deletions packages/clerk-js/rspack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,26 @@ const { merge } = require('webpack-merge');
const ReactRefreshPlugin = require('@rspack/plugin-react-refresh');
const { RsdoctorRspackPlugin } = require('@rsdoctor/rspack-plugin');

const enableReactCompiler = process.env.CLERK_REACT_COMPILER !== '0';
const toPosixPath = value => value.replace(/\\/g, '/');
const reactCompilerSourceRoots = [path.resolve(__dirname, 'src'), path.resolve(__dirname, 'sandbox')].map(toPosixPath);
const shouldCompileWithReactCompiler = filename => {
if (!enableReactCompiler) {
return false;
}

if (typeof filename !== 'string') {
return false;
}

const normalized = toPosixPath(filename);
if (normalized.includes('/node_modules/')) {
return false;
}

return reactCompilerSourceRoots.some(root => normalized.startsWith(root));
};

const isProduction = mode => mode === 'production';
const isDevelopment = mode => !isProduction(mode);

Expand Down Expand Up @@ -173,43 +193,93 @@ const svgLoader = () => {
};
};

/** @type {(options: { mode: 'development' | 'production' }) => import('@rspack/core').RuleSetUseItem | undefined} */
const createReactCompilerLoader = ({ mode }) => {
if (!enableReactCompiler) {
return undefined;
}

return {
loader: require.resolve('babel-loader'),
options: {
babelrc: false,
configFile: false,
cacheDirectory: true,
cacheCompression: false,
envName: mode,
parserOpts: {
sourceType: 'module',
plugins: [
'typescript',
'jsx',
'importAssertions',
'importMeta',
'classProperties',
'classPrivateProperties',
'classPrivateMethods',
'topLevelAwait',
],
},
plugins: [
[require.resolve('@babel/plugin-syntax-typescript'), { isTSX: true }],
[
require.resolve('babel-plugin-react-compiler'),
{
target: '18',
compilationMode: 'annotation',
sources: shouldCompileWithReactCompiler,
panicThreshold: mode === 'development' ? 'none' : 'critical_errors',
},
],
],
},
};
};

/** @type { (opts?: { targets?: string, useCoreJs?: boolean }) => (import('@rspack/core').RuleSetRule[]) } */
const typescriptLoaderProd = (
{ targets = packageJSON.browserslist, useCoreJs = false } = { targets: packageJSON.browserslist, useCoreJs: false },
{
targets = packageJSON.browserslist,
useCoreJs = false,
mode = 'production',
} = { targets: packageJSON.browserslist, useCoreJs: false, mode: 'production' },
) => {
return [
{
test: /\.(jsx?|tsx?)$/,
exclude: /node_modules/,
use: {
loader: 'builtin:swc-loader',
options: {
env: {
targets,
...(useCoreJs
? {
mode: 'usage',
coreJs: require('core-js/package.json').version,
}
: {}),
},
jsc: {
parser: {
syntax: 'typescript',
tsx: true,
use: [
createReactCompilerLoader({ mode }),
{
loader: 'builtin:swc-loader',
options: {
env: {
targets,
...(useCoreJs
? {
mode: 'usage',
coreJs: require('core-js/package.json').version,
}
: {}),
},
externalHelpers: true,
transform: {
react: {
runtime: 'automatic',
importSource: '@emotion/react',
development: false,
refresh: false,
jsc: {
parser: {
syntax: 'typescript',
tsx: true,
},
externalHelpers: true,
transform: {
react: {
runtime: 'automatic',
importSource: '@emotion/react',
development: false,
refresh: false,
},
},
},
},
},
},
].filter(Boolean),
},
{
test: /\.m?js$/,
Expand All @@ -234,30 +304,35 @@ const typescriptLoaderProd = (
};

/** @type { () => (import('@rspack/core').RuleSetRule[]) } */
const typescriptLoaderDev = () => {
const typescriptLoaderDev = ({ mode = 'development' } = {}) => {
return [
{
test: /\.(jsx?|tsx?)$/,
exclude: /node_modules/,
loader: 'builtin:swc-loader',
options: {
jsc: {
target: 'esnext',
parser: {
syntax: 'typescript',
tsx: true,
},
externalHelpers: true,
transform: {
react: {
runtime: 'automatic',
importSource: '@emotion/react',
development: true,
refresh: true,
use: [
createReactCompilerLoader({ mode }),
{
loader: 'builtin:swc-loader',
options: {
jsc: {
target: 'esnext',
parser: {
syntax: 'typescript',
tsx: true,
},
externalHelpers: true,
transform: {
react: {
runtime: 'automatic',
importSource: '@emotion/react',
development: true,
refresh: true,
},
},
},
},
},
},
].filter(Boolean),
},
];
};
Expand All @@ -271,7 +346,7 @@ const commonForProdChunked = (
) => {
return {
module: {
rules: [svgLoader(), ...typescriptLoaderProd({ targets, useCoreJs })],
rules: [svgLoader(), ...typescriptLoaderProd({ targets, useCoreJs, mode: 'production' })],
},
};
};
Expand All @@ -285,7 +360,7 @@ const commonForProdBundled = (
) => {
return {
module: {
rules: [svgLoader(), ...typescriptLoaderProd({ targets, useCoreJs })],
rules: [svgLoader(), ...typescriptLoaderProd({ targets, useCoreJs, mode: 'production' })],
},
};
};
Expand Down Expand Up @@ -575,7 +650,7 @@ const devConfig = ({ mode, env }) => {
const commonForDev = () => {
return {
module: {
rules: [svgLoader(), ...typescriptLoaderDev()],
rules: [svgLoader(), ...typescriptLoaderDev({ mode })],
},
plugins: [
new ReactRefreshPlugin(/** @type {any} **/ ({ overlay: { sockHost: devUrl.host } })),
Expand Down
Loading
Loading