-
Notifications
You must be signed in to change notification settings - Fork 419
chore(backend): Rename machine auth verification methods #7347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7beadc7
chore(backend): Rename machine auth verification methods
wobsoriano 289e04e
Merge branch 'main' into rob/user-4130-rename-verification-methods
wobsoriano bac3b5b
chore: add changeset
wobsoriano 842f09f
chore: update changeset
wobsoriano c8b3223
Merge branch 'main' into rob/user-4130-rename-verification-methods
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| '@clerk/backend': minor | ||
| --- | ||
|
|
||
| Unified machine token verification methods under a consistent `verify()` API. The previous methods (`verifySecret`, `verifyToken`, `verifyAccessToken`) are now deprecated. | ||
|
|
||
| Before | ||
|
|
||
| ```ts | ||
| await clerkClient.apiKeys.verifySecret('ak_...'); | ||
| await clerkClient.m2m.verifyToken({ token: 'mt_...' }); | ||
| ``` | ||
|
|
||
| After | ||
|
|
||
| ```ts | ||
| await clerkClient.apiKeys.verify('ak_...'); | ||
| await clerkClient.m2m.verify({ token: 'mt_...' }); | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 10 additions & 1 deletion
11
packages/backend/src/api/endpoints/IdPOAuthAccessTokenApi.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,24 @@ | ||
| import { joinPaths } from '../../util/path'; | ||
| import { deprecated } from '../../util/shared'; | ||
| import type { IdPOAuthAccessToken } from '../resources'; | ||
| import { AbstractAPI } from './AbstractApi'; | ||
|
|
||
| const basePath = '/oauth_applications/access_tokens'; | ||
|
|
||
| export class IdPOAuthAccessTokenApi extends AbstractAPI { | ||
| async verifyAccessToken(accessToken: string) { | ||
| async verify(accessToken: string) { | ||
| return this.request<IdPOAuthAccessToken>({ | ||
| method: 'POST', | ||
| path: joinPaths(basePath, 'verify'), | ||
| bodyParams: { access_token: accessToken }, | ||
| }); | ||
| } | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** | ||
| * @deprecated Use `verify()` instead. This method will be removed in the next major release. | ||
| */ | ||
| async verifyAccessToken(accessToken: string) { | ||
| deprecated('idPOAuthAccessToken.verifyAccessToken()', 'Use `idPOAuthAccessToken.verify()` instead.'); | ||
| return this.verify(accessToken); | ||
| } | ||
wobsoriano marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.