-
Notifications
You must be signed in to change notification settings - Fork 419
chore(backend): Fix ClerkRequest helper instance check #7431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…vironments Replace instanceof check with duck typing to fix issue where bundlers create multiple Request class instances, causing instanceof ClerkRequest to incorrectly return true for regular Request objects. This fixes the issue in TanStack Start and other environments where polyfilled or scoped Request classes break instanceof checks. Co-authored-by: chris-kreidl <chris-kreidl@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 82a182b The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
jacekradko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Description
Replace instanceof check with duck typing to fix issue where bundlers create multiple
Requestclass instances, causinginstanceof ClerkRequestto incorrectly return true for regularRequestobjects.This fixes the issue in TanStack React Start (#6996) and other environments where polyfilled or scoped
Requestclasses breakinstanceofchecks.Builds on top of #7421
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change