Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Jan 5, 2026

Description

Noticed in #7534 that the Alert component has two Text component usages but there is no way to target a specific one. This PR adds data attributes that map to the variant and colorScheme usage similar to our Button component https://github.com/clerk/javascript/blob/main/packages/ui/src/primitives/Button.tsx#L273-L274

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026

🦋 Changeset detected

Latest commit: 15e7462

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jan 5, 2026 8:49pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 5, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7535

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7535

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7535

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7535

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7535

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7535

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7535

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7535

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7535

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7535

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7535

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7535

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7535

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7535

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7535

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7535

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7535

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7535

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7535

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7535

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7535

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7535

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7535

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7535

commit: 15e7462

Copy link
Member

@brkalow brkalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go into main as well right?

@alexcarpenter
Copy link
Member Author

This should go into main as well right?

Yup, cherrying-picking the changes into main 👍🏼

@alexcarpenter alexcarpenter merged commit 2eaa829 into release/core-2 Jan 5, 2026
78 of 79 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/text-data-attrs branch January 5, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants