Fix VS Code integration when ESLint project outside VS Code project #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an ESLint project is not in the root directory, e.g. + our-project |--+ client | |--- src/ | |--- package.json | |--- eslint-local-rules.js |--+ server | |--- stuff Some editor plugins does not `cd` into `client` directory when invoking ESLint. Therefore `process.cwd()` is "our-project", which means `requireUp` will not find our "eslint-local-rules.js". This problem is fixed by making this plugin require from `__dirname` instead of `process.cwd()`. Intuitively, the behavior of the plugin should not depend on where it is run. This commit also makes `eslint-plugin-local-rules` fail loudly if the rules file is not found.
|
Awesome, thanks! And your https://github.com/taskworld/eslint-plugin-local looks pretty sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ESLint project is not in the root directory, e.g.
Some editor plugins does not
cdintoclientdirectory when invoking ESLint. Thereforeprocess.cwd()is "our-project", which meansrequireUpwill not find our "eslint-local-rules.js".This problem is fixed by making this plugin require from
__dirnameinstead ofprocess.cwd(). Intuitively, the behavior of the plugin should not depend on where it is run.This commit also makes
eslint-plugin-local-rulesfail loudly if the rules file is not found.