Skip to content

Apply Symfony best practices #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 of 8 tasks
njoubert-cleverage opened this issue Oct 24, 2024 · 0 comments
Closed
5 of 8 tasks

Apply Symfony best practices #2

njoubert-cleverage opened this issue Oct 24, 2024 · 0 comments
Assignees
@njoubert-cleverage
Milestone
v2.0

Comments

@njoubert-cleverage
Copy link
Member

njoubert-cleverage commented Oct 24, 2024 •
edited
Loading

Description

From : https://symfony.com/doc/current/bundles/best_practices.html

  • Directory Structure
  • Documentation
  • Services
  • Routing

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes
@njoubert-cleverage njoubert-cleverage added this to the v2.0 milestone Oct 24, 2024
@njoubert-cleverage njoubert-cleverage self-assigned this Oct 24, 2024
njoubert-cleverage added a commit that referenced this issue Oct 28, 2024
@njoubert-cleverage
#2 Routes must be prefixed with the bundle alias => `cleverage_ui_pro…
ae13795 
…cess`
njoubert-cleverage added a commit that referenced this issue Oct 28, 2024
@njoubert-cleverage
#2 Update services according to Symfony best practices. Services shou…
913a51f 
…ld not use autowiring or autoconfiguration. Instead, all services should be defined explicitly. Services must be prefixed with the bundle alias instead of using fully qualified class names => `cleverage_ui_process`
njoubert-cleverage added a commit that referenced this issue Oct 30, 2024
@njoubert-cleverage
#2 Fix some services definitions
533efd8
njoubert-cleverage added a commit that referenced this issue Oct 30, 2024
@njoubert-cleverage
#2 Fix some services definitions
7cec21e
njoubert-cleverage added a commit that referenced this issue Oct 30, 2024
@njoubert-cleverage
#2 Rollback controller services defintion that doesn't work with Easy…
ca7fe4e 
…Admin
njoubert-cleverage added a commit that referenced this issue Oct 30, 2024
@njoubert-cleverage
#2 Fix some services & controllers definitions
6bcf10a
njoubert-cleverage added a commit that referenced this issue Oct 30, 2024
@njoubert-cleverage
#2 Update repositories definitions (that doesn't work on vendor when …
c10cf5c 
…using ServiceEntityRepository / repositoryClass: ***) with Doctrine\ORM\EntityRepository. Update others services to use injected repostories services instead of $em->getRepository(....)
njoubert-cleverage added a commit that referenced this issue Oct 30, 2024
@njoubert-cleverage
#2 Remove wrong readonly on Process.$executions
e3bc44f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njoubert-cleverage njoubert-cleverage

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@njoubert-cleverage