forked from DataBiosphere/data-browser
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement header nav "More" and "Follow Us" menu #592
Comments
HI @Arctenik, do you have enough information to start on this? Thanks, D |
Arctenik
added a commit
that referenced
this issue
Nov 1, 2022
Arctenik
added a commit
that referenced
this issue
Nov 2, 2022
Arctenik
added a commit
that referenced
this issue
Nov 3, 2022
frano-m
pushed a commit
that referenced
this issue
Nov 3, 2022
@frano-m Is my part of this finished? |
@hunterckx yes thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Implement configurable header nav menu for the "More" and "Follow Us" buttons to match mocks here and here using SB (Storybook).
Approach
NavLinkMenu
inexplorer/app/components/Layout/components/Header/components/NavLinkMenu
NavLinkMenu
styles file for style overrides.NavLinkMenu.stories.tsx
inexplorer/app/components/Layout/components/Header/components/NavLinkMenu
.npm run storybook
to style and develop the new component.explorer/app/components/CheckboxMenu/checkboxMenu.tsx
for an example use of Mui Menu. See also an example of an icon menu and menu api.CheckboxMenu
for an example on how to control the menu show/hide state. We will be usinganchorEl
to set the position of the menu.theme.ts
->MuiPaper
->styleOverrides
->menu
for the css specification. Override any theme styles as required (e.g. border colour).<button>
HTML element to control the show/hide of the menu.MenuItem
interface, comprising of the following:icon
- ReactNode, optional.label
- string, required.url
- string, required.menuItems
-MenuItem[]
, required.menuLabel
- string, required.icon
prop in SB for the "Follow Us" menu, seeexplorer/app/components/common/Socials/socials.tsx
,CustomIcon
to generate social icons.Definition of Done
The text was updated successfully, but these errors were encountered: