fix(config): Handle newlines in YAMPL_VALUE env

clevyr · Jun 26, 2024 · 3c0bb1e · 3c0bb1e
1 parent 812db1d
commit 3c0bb1e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/internal/config/values_hack.go b/internal/config/values_hack.go
@@ -2,6 +2,7 @@ package config
 
 import (
 	"bufio"
+	"os"
 	"strings"
 )
 
@@ -29,6 +30,10 @@ func FixStringToStringNewlines(s []string) []string {
 			result = append(result, arg)
 		}
 	}
+	envName := EnvPrefix + strings.ToUpper(ValueFlag)
+	if env := os.Getenv(envName); env != "" {
+		_ = os.Setenv(envName, strings.ReplaceAll(env, "\n", ","))
+	}
 	return result
 }
 

diff --git a/internal/config/values_hack_test.go b/internal/config/values_hack_test.go
@@ -1,12 +1,19 @@
 package config
 
 import (
+	"os"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 )
 
 func TestFixStringToStringNewlines(t *testing.T) {
+	t.Run("env", func(t *testing.T) {
+		t.Setenv("YAMPL_VALUE", "a=a\nb=b")
+		FixStringToStringNewlines([]string{})
+		assert.Equal(t, "a=a,b=b", os.Getenv("YAMPL_VALUE"))
+	})
+
 	type args struct {
 		s []string
 	}