WIP Prototype using charmbracelet/huh for prompter #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates cli/cli#8084 Relates #164 With go-survey/survey being unmaintained, this is an initial prototype of using https://github.com/charmbracelet/huh as an optional prompting experience including support for accessiblity needs. Additionally, this commit includes a simple example to demo the existing and new experiences in `examples/prompter/main.go`: - by default, the existing go-survey/survey experience - specifying `GH_PROMPTER=accessible`, the new charmbracelet/huh experience in rich mode - specifying `ACCESSIBLE=1` with `GH_PROMPTER=accessible`, the new charmbracelet/huh experience in accessible mode
andyfeller
commented
Jun 24, 2024
| stderr io.Writer | ||
| } | ||
|
|
||
| func NewAccessiblePrompter(stdin io.Reader, stdout io.Writer, stderr io.Writer) *AccessiblePrompter { |
There was a problem hiding this comment.
Feedback from @maaslalani : rename this to something like GlamorousPrompter
andyfeller
commented
Jun 24, 2024
| stderr FileWriter | ||
| } | ||
|
|
||
| func NewLegacyPrompter(stdin FileReader, stdout FileWriter, stderr FileWriter) *LegacyPrompter { |
There was a problem hiding this comment.
Alternate naming option: GoSurveyPrompter
andyfeller
commented
Jun 24, 2024
| @@ -32,103 +34,40 @@ type FileReader interface { | |||
|
|
|||
| // New instantiates a new Prompter. | |||
| func New(stdin FileReader, stdout FileWriter, stderr FileWriter) *Prompter { | |||
| // TODO: Enhance logic to look at configuration for prompter type. | |||
| prompterType := os.Getenv("GH_PROMPTER") | |||
There was a problem hiding this comment.
Idea from @maaslalani : what if we forced GH_PROMPTER to the new glamorous prompter experience if ACCESSIBLE=1?
main concern about how the user's experience with 3rd party extensions would play out when they eventually upgrade cli/go-gh but didn't consider the changes 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates cli/cli#8084
Relates #164
With go-survey/survey being unmaintained, this is an initial prototype of using https://github.com/charmbracelet/huh as an optional prompting experience including support for accessiblity needs.
Additionally, this commit includes a simple example to demo the existing and new experiences in
examples/prompter/main.go:GH_PROMPTER=accessible, the new charmbracelet/huh experience in rich modeACCESSIBLE=1withGH_PROMPTER=accessible, the new charmbracelet/huh experience in accessible modeScreenshare.-.2024-06-03.10_26_38.AM.mp4