Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditionally resolve "ssh.github.com" to "github.com" #68

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Unconditionally resolve "ssh.github.com" to "github.com" #68

merged 1 commit into from
Aug 25, 2022

Conversation

samcoe
Copy link
Contributor

@samcoe samcoe commented Aug 25, 2022

This functionality diverged (cli/cli@c240ab9) while migrating to go-gh for ssh config file parsing and translation so just re-adding it back in.

Fixes cli/cli#6125

@samcoe samcoe self-assigned this Aug 25, 2022
@samcoe samcoe requested a review from vilmibm August 25, 2022 10:32
@samcoe samcoe merged commit 34c1b91 into trunk Aug 25, 2022
@samcoe samcoe deleted the fix-ssh-translation branch August 25, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilmibm vilmibm vilmibm approved these changes

Assignees

@samcoe samcoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Something in release 2.12.1 causes .ssh/config file to be ignored, breaking gh in all later releases.
2 participants
@samcoe @vilmibm