Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on osx, install curl using brew #253

Merged
merged 1 commit into from
Jun 14, 2021
Merged

on osx, install curl using brew #253

merged 1 commit into from
Jun 14, 2021

Conversation

andy5995
Copy link
Contributor

@andy5995 andy5995 commented Jun 6, 2021

No description provided.

Copy link

@xSavitar xSavitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The command for installing brew is valid but the only issue could be if brew itself is not installed (as it doesn't come in-built in osx) but if it is, this works just great. Thanks :)

@andy5995
Copy link
Contributor Author

andy5995 commented Jun 8, 2021

You're welcome.

This is what's installed:

https://github.com/actions/virtual-environments/blob/macOS-10.15/20210531.1/images/macos/macos-10.15-Readme.md

Maybe you could use vcpkg to install curl on the Windows test build?

@andy5995
Copy link
Contributor Author

andy5995 commented Jun 8, 2021

You're welcome.

This is what's installed:

https://github.com/actions/virtual-environments/blob/macOS-10.15/20210531.1/images/macos/macos-10.15-Readme.md

Maybe you could use vcpkg to install curl on the Windows test build?

I just noticed under the Utilities section that curl is already installed.

Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephenmathieson stephenmathieson merged commit 20e0c68 into clibs:master Jun 14, 2021
@stephenmathieson
Copy link
Member

Tests failed on the master branch: https://github.com/clibs/clib/runs/2823085469. I don't think this works

@andy5995
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants