Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not discard const type qualifier #300

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Nov 6, 2023

In the changed code, name is assigned a pointer, that was some offset value from manifest_names.

manifest_names is defined like so:

extern const char *manifest_names[];

In all cases, name is being passed into the fs_read function, which has the following declaration:

char *fs_read (const char *path);

Because the "source" and "destination" of name has a type of const char *, changing name to match that improves consistensy. This also fixes a -Wdiscarded-qualifiers warning that may show upon compilation.

@jwerle jwerle merged commit e47d7fa into clibs:master Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants