fix: Do not discard const
type qualifier
#300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the changed code,
name
is assigned a pointer, that was some offset value frommanifest_names
.manifest_names
is defined like so:In all cases,
name
is being passed into thefs_read
function, which has the following declaration:Because the "source" and "destination" of
name
has a type ofconst char *
, changingname
to match that improves consistensy. This also fixes a-Wdiscarded-qualifiers
warning that may show upon compilation.