Fix failing tests, cleanup issues w/running tests locally #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Only run cache tests once This fix ensures the test script only runs the cache tests once, as intended. Prior, the cache test binary would get picked up by the `find` in test.sh and execute. Because we don't explicitly run `make clean` here, subsequent test runs always fail. `# Please enter the commit message for your changes. Lines starting
jwerle
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the issues in this ci failure and false negatives when running tests locally (e.g. due to inadvertently running the cache tests twice).
Changes:
Thanks
@jwerle @stephenmathieson