-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use entrypoint resolve to not check all the dependencies in the env #32
base: main
Are you sure you want to change the base?
Conversation
@cpaulik A cursory look at the docs for A few questions:
|
At the moment this is as simple as
You should get the warning
at the end of the installation.
The problem in my view is that this breaks perfectly working plugins. If pip can not resolve the environment correctly a dependency of a dependency might be wrong. This can happen quite often in complex projects because of the shortcomings of pip. The current behavior means that the plugin does not work at all even if the plugin does not use any of the features of the dependency of the dependency and will work perfectly. So my suggestion is to replace the error by a warning that not all dependencies are correctly installed. Similar to what pip does at the moment. This warning would still need to be implemented in this PR.
I can do that if we agree that this is a problem that needs fixing. |
Any updates on if this is worth doing? It is still biting us regularly. |
@cpaulik Yeah will try to revisit this weekend. |
Fixed PR click-contrib#32 name.
I can adapt the tests etc. If you agree that this is a workable way and if this issue is indeed a problem you don't want to see.
Fix #31