Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a shortest_only option #105

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Add a shortest_only option #105

merged 2 commits into from
Jul 15, 2023

Conversation

ZanyMonk
Copy link
Contributor

The ClickCompleter can now receive a shortest_only keyword argument.

If set to True, only the shortest version of each option will be shown by default (ie. if we keep pressing Tab & Space).

Before

> cmd <TAB>
            --verbose
            -v
> cmd -<TAB>
            --verbose
            -v

After

> cmd <TAB>
            -v
> cmd -<TAB>
            --verbose
            -v

@auvipy auvipy self-requested a review June 22, 2023 04:35
@ZanyMonk
Copy link
Contributor Author

Fixed the format to fit flake8 test.

auvipy
auvipy requested changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please rebase?

@ZanyMonk ZanyMonk requested a review from auvipy July 12, 2023 17:41
@auvipy
Copy link
Collaborator

auvipy commented Jul 13, 2023

@GhostOps77

@GhostOps77
Copy link
Contributor

@auvipy yep, this one looks good too!
and works very well.
You can merge this PR without any issues.

@auvipy auvipy merged commit 0c32dce into click-contrib:master Jul 15, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZanyMonk @auvipy @GhostOps77