Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added repl context object #117

Closed
wants to merge 4 commits into from

Conversation

GhostOps77
Copy link
Contributor

similar to click's context object, but its for keeping track on the promptsession object.

By this, the user can modify the prompt in runtime, can also change the prompt text, and view history.

@GhostOps77
Copy link
Contributor Author

@auvipy can u review this pls?

@auvipy
Copy link
Collaborator

auvipy commented May 1, 2024

Yes

Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking the code changes, it seems to be a big rewrite but without any additional test cases. it would be helpful to know more detail about the goal of the change

@GhostOps77
Copy link
Contributor Author

GhostOps77 commented May 1, 2024

its just for giving the user full control over the prompt session object for utmost customization of the prompt.
changing prompt, and checking commands history are just some of them.

its also used for keeping track of each of its appropriate repl session, which will be useful if a repl is invoked inside an another repl

therefore, this PR is more like a feature request

@GhostOps77 GhostOps77 requested a review from auvipy May 1, 2024 17:22
@GhostOps77
Copy link
Contributor Author

@auvipy any more queries?

@GhostOps77 GhostOps77 closed this May 4, 2024
@GhostOps77 GhostOps77 deleted the repl-ctx branch May 4, 2024 02:12
@GhostOps77 GhostOps77 restored the repl-ctx branch May 4, 2024 02:12
@GhostOps77 GhostOps77 deleted the repl-ctx branch May 4, 2024 02:12
@auvipy
Copy link
Collaborator

auvipy commented May 4, 2024

why it was closed?

@GhostOps77
Copy link
Contributor Author

@auvipy i included a small, dead code
idk how to rebase
so i deleted the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants