feat(db-ops): Allow schemas to have ownership set at creation [ENG_OPER-10194] #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricklenclickup
commented
Oct 10, 2025
| @@ -1,6 +1,9 @@ | |||
| DROP FUNCTION IF EXISTS microsharding_ensure_exist(integer, integer); | |||
There was a problem hiding this comment.
Was going to add the entire file in a transaction but decided against it.
The DROP FUNCTION above is to ensure the old function is removed if it exists.
ballen-clickup
approved these changes
Oct 10, 2025
| COMMENT ON FUNCTION microsharding_ensure_exist(integer, integer) | ||
| IS 'Creates shards (schemas) in the range shard_from..shard_to (inclusive).'; | ||
| COMMENT ON FUNCTION microsharding_ensure_exist(integer, integer, varchar) | ||
| IS 'Creates shards (schemas) in the range shard_from..shard_to (inclusive).'; |
There was a problem hiding this comment.
sorry nit: can we have new line here
|
Closing in favour of time-loop#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow microsharding schemas to be created with a specific owner.
https://app.clickup-stg.com/t/333/ENG_OPER-10194