Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSL Support for MySQL #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SSL Support for MySQL #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions core/src/plugins/mysql/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
package mysql

import (
"crypto/tls"
"crypto/x509"
"fmt"
"net/url"
"os"

"github.com/clidey/whodb/core/src/common"
"github.com/clidey/whodb/core/src/engine"
mysql_driver "github.com/go-sql-driver/mysql"
"gorm.io/driver/mysql"
"gorm.io/gorm"
)
Expand All @@ -16,6 +20,10 @@ const (
parseTimeKey = "Parse Time"
locKey = "Loc"
allowClearTextPasswordsKey = "Allow clear text passwords"
sslModeKey = "SSL Mode"
sslCAKey = "SSL CA"
sslCertKey = "SSL Cert"
sslKeyKey = "SSL Key"
)

func DB(config *engine.PluginConfig) (*gorm.DB, error) {
Expand All @@ -25,6 +33,20 @@ func DB(config *engine.PluginConfig) (*gorm.DB, error) {
loc := common.GetRecordValueOrDefault(config.Credentials.Advanced, locKey, "Local")
allowClearTextPasswords := common.GetRecordValueOrDefault(config.Credentials.Advanced, allowClearTextPasswordsKey, "0")

sslMode := common.GetRecordValueOrDefault(config.Credentials.Advanced, sslModeKey, "")
sslCA := common.GetRecordValueOrDefault(config.Credentials.Advanced, sslCAKey, "")
sslCert := common.GetRecordValueOrDefault(config.Credentials.Advanced, sslCertKey, "")
sslKey := common.GetRecordValueOrDefault(config.Credentials.Advanced, sslKeyKey, "")

tlsConfigName := ""
if sslMode != "" && sslCA != "" && sslCert != "" && sslKey != "" {
var err error
tlsConfigName, err = registerTLSConfig(sslCA, sslCert, sslKey)
if err != nil {
return nil, fmt.Errorf("failed to register TLS config: %v", err)
}
}

params := url.Values{}

for _, record := range config.Credentials.Advanced {
Expand All @@ -37,9 +59,41 @@ func DB(config *engine.PluginConfig) (*gorm.DB, error) {
}

dsn := fmt.Sprintf("%v:%v@tcp(%v:%v)/%v?charset=%v&parseTime=%v&loc=%v&allowCleartextPasswords=%v&%v", config.Credentials.Username, config.Credentials.Password, config.Credentials.Hostname, port, config.Credentials.Database, charset, parseTime, loc, allowClearTextPasswords, params.Encode())

if tlsConfigName != "" {
dsn += fmt.Sprintf("&tls=%v", tlsConfigName)
}

db, err := gorm.Open(mysql.Open(dsn), &gorm.Config{})
if err != nil {
return nil, err
}
return db, nil
}

func registerTLSConfig(caFile, certFile, keyFile string) (string, error) {
rootCertPool := x509.NewCertPool()

caPem, err := os.ReadFile(caFile)
if err != nil {
return "", fmt.Errorf("failed to read CA certificate: %v", err)
}

if ok := rootCertPool.AppendCertsFromPEM(caPem); !ok {
return "", fmt.Errorf("failed to append CA certificate")
}

clientCert, err := tls.LoadX509KeyPair(certFile, keyFile)
if err != nil {
return "", fmt.Errorf("failed to load client certificate: %v", err)
}

tlsConfig := &tls.Config{
RootCAs: rootCertPool,
Certificates: []tls.Certificate{clientCert},
}

mysql_driver.RegisterTLSConfig("custom", tlsConfig)

return "custom", nil
}
4 changes: 2 additions & 2 deletions frontend/src/pages/auth/login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const databaseTypeDropdownItems: IDropdownItem<Record<string, string>>[] = [
id: "MySQL",
label: "MySQL",
icon: Icons.Logos.MySQL,
extra: {"Port": "3306", "Charset": "utf8mb4", "Parse Time": "True", "Loc": "Local", "Allow clear text passwords": "0"},
extra: {"Port": "3306", "Charset": "utf8mb4", "Parse Time": "True", "Loc": "Local", "Allow clear text passwords": "0", "SSL Mode": "", "SSL CA": "", "SSL Cert": "", "SSL Key": ""},
},
{
id: "MariaDB",
Expand Down Expand Up @@ -277,7 +277,7 @@ export const LoginPage: FC = () => {
{error}
</div>
</div>
<div className="flex flex-col grow justify-center gap-1">
<div className="flex flex-col grow gap-1">
<DropdownWithLabel fullWidth label="Database Type" value={databaseType} onChange={handleDatabaseTypeChange} items={databaseTypeDropdownItems} />
{fields}
</div>
Expand Down