Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redmine update #10

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Redmine update #10

merged 6 commits into from
Jan 22, 2024

Conversation

jirihofman
Copy link
Member

@jirihofman jirihofman commented Jan 19, 2024

What

  • correctly handle arrays. As strings in inspector, parse them in receive()
  • Add outputType option to IssuesFind by adding x-connector-pagination extension
  • Improve some labels and their examples
  • Refactor updated openapi spec to use refs.
  • Improve test flow

Monday

Some unrelated Monday changes needed here in order to make the CI pass. These changes were merged before CI checks were introduced.

  • eslint fix. No connector updated needed there.
  • test fix - ignore outputType checks

@jirihofman jirihofman self-assigned this Jan 19, 2024
Update examples values in JSON and YAML files
- test outputType options
- verify deleted issue
"path": "issue.custom_fields",
"originalType": "array",
"items": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jirihofman Since you changed the type from an array to a string, do we still need to keep these items?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need items anymore but that would need to be handled in the generator. As of now it keeps many other properties there if they are in openAPI specs even though Appmixer doesn't use them.

Definitely a good idea to start removing them in the generator so that our component.json files are smaller.

@vtalas vtalas merged commit d62cf41 into clientIO:dev Jan 22, 2024
1 check passed
@jirihofman jirihofman deleted the redmine-update branch January 24, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants