-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asana.CreateProject (patch update) Color Palette not showing colors #208
Open
sayam-nasir
wants to merge
7
commits into
clientIO:dev
Choose a base branch
from
sayam-nasir:Asana-sanity-issues
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
26250d8
fixing color-palete for Create Project and component descriptions
sayam-nasir 9700a03
es-lint1
sayam-nasir 2b25e1c
bundle.json
sayam-nasir deeac5d
added complete output port options
sayam-nasir 1aee5c2
udpated output port labels
sayam-nasir 4a0676b
removing the changes
sayam-nasir 3e54cc5
added a mapper for asana colors in the NewProject.js
sayam-nasir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the inspector is generated dynamically due to this color palette inputs, is that right?
is it really needed? it's only converting hard-coded
asanaColorMap
to another format (key: value -> value:key) why it's not in the{value: hex, content: "name"}
directly in the component.json?it could be reasonable if the
asanaColorMap
is somehow configurable.BTW you don't need to make the whole inspector dynamic because of one input, you can generate inspector field separately, like it's here:
appmixer-connectors/src/appmixer/utils/forms/FormTrigger/component.json
Line 22 in 73c79f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vtalas youre right,
I will just take the input from the user, keep inspector in component.json. Create a mapper in CreateProject.js that will map user's input to asana specific color names and send to the API that will be cleaner simpler solution