Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shapes)!: remove devs shapes; update standard shapes #2425

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

kumilingus
Copy link
Contributor

@kumilingus kumilingus commented Dec 11, 2023

Description

This is the second PR that removes shapes from joint-core (See #2422).

Completely removing legacy shapes from the joint-core package.

  • devs were removed from joint-core and are implemented only as custom shapes within the demos.

Migration guide

You can copy the shape definition from v3.7 directly to your application.
Here are examples: devs


The PR also updates the standard shapes not to use legacy attributes such as refWidth, refHeight, refX, refY, etc.
and use native SVG attributes with calc expressions.

For instance refWidth: 100%; is replaced with width: 'calc(w)'.

If you change these values in your application (e.g. by changing the refD attribute of the path or changing the position of the label using refY), this is another breaking change.

Migration guide

  • a. You can copy the shape definition from v3.7 directly to your application and override the built-in ones.
  • b. You need to switch from ref* attributes to native attributes in your code and you might also need to change the attributes in any JSON you try to import (should the JSON contain modified standard shapes ref* attributes).

@zbynekstara zbynekstara merged commit d7f83b5 into clientIO:dev Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants