refactor(shapes)!: remove devs shapes; update standard shapes #2425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the second PR that removes shapes from joint-core (See #2422).
Completely removing legacy shapes from the joint-core package.
devs
were removed fromjoint-core
and are implemented only as custom shapes within the demos.Migration guide
You can copy the shape definition from
v3.7
directly to your application.Here are examples: devs
The PR also updates the
standard
shapes not to use legacy attributes such asrefWidth
,refHeight
,refX
,refY
, etc.and use native SVG attributes with
calc
expressions.For instance
refWidth: 100%;
is replaced withwidth: 'calc(w)'
.If you change these values in your application (e.g. by changing the
refD
attribute of the path or changing the position of the label usingrefY
), this is another breaking change.Migration guide
v3.7
directly to your application and override the built-in ones.ref*
attributes to native attributes in your code and you might also need to change the attributes in any JSON you try to import (should the JSON contain modifiedstandard
shapesref*
attributes).