Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dia.LinkView)!: remove support for legacy link view #2446

Merged
merged 14 commits into from
Dec 19, 2023

Conversation

kumilingus
Copy link
Contributor

Description

Remove support for legacy features of joint.dia.LinkView (It has long been deprecated due to poor performance caused by built-in link tools that had to be rendered for each link at start-up (even though they are only visible when the user hovers over them).

  • joint.dia.Link has no markup defined and effectively becomes an abstract class
  • drop support for semantic string markup (connection, connection-wrap, marker-source, marker-target, marker-vertices, marker-arrowheads, link-tools in the markup has no longer effect on the user interactivity).
  • drop support for vertexAdd, vertexRemove, vertexMove, arrowheadMove, useLinkTools interactivity paper options
  • the following protected methods has been removed for LinkView: dragConnectionStart, dragConnection, dragConnectionEnd, dragVertexStart, dragVertex, dragVertexEnd
  • the paper defaultLink is now standard.Link

The linkTools.Vertices tools now accept 2 new options: vertexAdding and vertextRemoving

Migration guide

Switch to joint.shapes.standard.Link and add link tools dynamically.

For the interactive options:

  • vertexAdd, vertexRemove & vertexMove - add linkTools.Vertices to enable the user to interact with vertices

    new linkTools.Vertices({ vertexAdding: boolean, vertextMoving: boolean, vertextRemoving: boolean })
  • arrowheadMove - add linkTools.Arrowhead to enable arrowhead move

  • useLinkTools - add linkTools.Button to the link view

Co-authored-by: Zbynek Stara <zbynek.stara.internet@hotmail.com>
@zbynekstara zbynekstara merged commit 72b070b into clientIO:dev Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants