Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate material UI to version5 #21

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

gautamjajoo
Copy link
Collaborator

@gautamjajoo gautamjajoo commented Jun 14, 2022

Fixes #5.

Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first review pass with a couple of commets

.env.local Outdated Show resolved Hide resolved
components/appbar/BasicAppBar.component.jsx Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
pages/index.tsx Outdated Show resolved Hide resolved
@vincenzopalazzo
Copy link
Member

Ok, The import was the problem, this is the bad side of using an automation tool.

In addition, the theme needs to be adapted to this https://material-theme.com/docs/reference/color-palette/#material-themes and the migration needs to reflect the actual theme on production https://bruce.lnmetrics.info/

@vincenzopalazzo
Copy link
Member

In addition, the deprecation of the Metrics UI looks like not finished!

theme/DarkTheme.ts Outdated Show resolved Hide resolved
theme/DarkTheme.ts Outdated Show resolved Hide resolved
theme/DarkTheme.ts Outdated Show resolved Hide resolved
@vincenzopalazzo vincenzopalazzo self-assigned this Jun 15, 2022
@vincenzopalazzo vincenzopalazzo merged commit 706153d into clightning4j:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate material UI from 4 to version5
2 participants