-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build and plugin packages to support JS code generation #479
Comments
Here's a summary of the changes that were included in this branch. Most of these changes will have no impact on users, except for the first one flagged below with the API changes in the
|
chrispcampbell
added a commit
that referenced
this issue
May 24, 2024
Merged
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After we add the initial support for JS code generation in the cli, compile, and runtime packages (see #437), we need to update the following packages to allow for choosing between C and JS code generation:
In the
UserConfig
interface (andsde.config.js
file), I will add a switch to control which code format to generate:In the
Plugin
interface, I'm planning to removepre/postGenerateC
and replace them with:Currently plugin-worker assumes that plugin-wasm is used, and has code that is specific to the wasm case (like initializing a
WasmModel
that includes theoutputVarIds
). I plan to change this so that plugin-wasm injects theoutputVarIds
into the generated module. That way, plugin-worker can be simplified to load either a Wasm model or a JS model.The text was updated successfully, but these errors were encountered: