Debugging and adding a failing test.

[THOR300]

Description

This test is just to make it super clear that we are not getting geographies back from vespa (not necessarily looking to merge).

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

• Skip auto-tagging
• [] Patch
• Minor version
• Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

• If none of these options are selected, auto-tagging will fail (integrated soon)
• Where multiple options are selected, the most senior option ticked will be
  used -- e.g. Major > Minor > Patch
• If you are selecting the version in the list above using the textbox, make
  sure your selected option is marked [x] with no spaces in between the
  brackets and the x

Type of change

Please select the option(s) below that are most relevant:

• Bug fix
• New feature
• Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Before submitting

• I've read and followed all steps in the Making a pull request
  section of the CONTRIBUTING docs.
• I've updated or added any relevant docstrings following the syntax described in the
  Writing docstrings section of the CONTRIBUTING docs.
• If this PR fixes a bug, I've added a test that will fail without my fix.
• If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

[THOR300]

Bug

No geographies in search response on staging when using “exact match, region, query”

We have test coverage for this so how did this get through?

• I’ve added a failing test that mimics this permutation of search filters on the app.
  • Debugging and adding a failing test. #108
• The issue comes from the query returning only passage hits and not document hits. Passages seem to be coming back with no geographies field.
  • Why this occurs I’m not sure.
• I’ve validated locally by stepping through the code that we are getting geographies back for the relevant tests in the backend and cpr_sdk.
  • Geographies is present for these as we do get document hits.

So why does this failing test get no document hits whereas others do?

• I’m searching for ‘e’ in the test that fails to return document type responses, that text definitely exists in the titles of the documents?

No document type hits = No geographies in response

CPR_SDK
Calling staging:

• Confirmed that on staging we are getting no hits with geographies present in the vespa_response
  • This means that when we try and create Passage type hits there’s no geographies present.
  • How? By using the sdk with the correct certs and putting in a breakpoint in the code before we post process
• Confirmed that we are only getting passage and not document hits when calling the staging instance.

Tests:

• Confirmed that there are no document type hits and no geographies in the response using this test:
  • tests/test_search_adaptors.py::test_vespa_search_response__geographies
• Confirmed that there are document type hits and geographies present in this test:
  • tests/test_search_adaptors.py::test_vespa_search_adaptor__filters

BACKEND

• Confirmed that on main in the backend we are getting geographies in results in tests and this is why they are passing.
  • Using this test and adding a breakpoint: tests/search/vespa/test_vespa_search.py::test_metadata_filter

Potential Fixes:

Two options:

1. Get geographies back for all query behaviour

This is confusing as it should be a join on the family!

• Adding geographies to the document_passage summary does not fix this either!

2. Try and understand why some query behaviour only returns passages and change it to always return geographies.

[jesse-c]

LGTM

Took me a second to appreciate the asserts in the test. 😅