Surface concept schema changes via sdk query updates

src/cpr_sdk/models/search.py

@@ -1,6 +1,6 @@
 import re
 from datetime import datetime
-from typing import List, Optional, Sequence
+from typing import List, Literal, Optional, Sequence
 
 from pydantic import (
     AliasChoices,
@@ -45,6 +45,69 @@ class MetadataFilter(BaseModel):
     value: str
 
 
+class ConceptFilter(BaseModel):
+    """A filter for concept fields"""
+
+    name: Literal["name", "id", "model", "timestamp", "parent_concept_ids_flat"]
+    value: str
+
+    @model_validator(mode="after")
+    def validate_parent_concept_ids_flat(self) -> "ConceptFilter":
+        """
+        Validate parent_concept_ids_flat field.
+
+        If the schema we comma separate values in the parent_concept_ids_flat field.
+        This means we must ensure that the last character is a comma to avoid the
+        situation below.
+
+        E.g. parent_concept_ids_flat: "Q1" should be parent_concept_ids_flat: "Q1,"
+        but you will also return "Q12, Q123," which is invalid.
+        """
+        if self.name == "parent_concept_ids_flat" and self.value[-1] != ",":
+            self.value = self.value + ","
+        return self
+
+
+class Concept(BaseModel):
+    """
+    A concept extracted from a passage of text.
+
+    This refers to a span of text within passage that holds a concept.
+    E.g. "Adaptation strategy" is a concept within a passage starting at index 0 and
+    ending at index 17.
+    """
+
+    id: str
+    name: str
+    parent_concepts: List[dict[str, str]]
+    parent_concept_ids_flat: str
+    model: str
+    end: int
+    start: int
+    timestamp: datetime
+
+    @model_validator(mode="after")
+    def validate_parent_concept_ids_flat(self) -> "Concept":
+        """
+        Validate parent_concept_ids_flat field.
+
+        This field should hold the same concepts as the parent_concepts field.
+        """
+        parent_concept_ids_flattened = ",".join(
+            [parent_concept["name"] for parent_concept in self.parent_concepts]
+        )
+
+        if parent_concept_ids_flattened[-1] != ",":
+            parent_concept_ids_flattened += ","
+
+        if not self.parent_concept_ids_flat == parent_concept_ids_flattened:
+            raise ValueError(
+                "parent_concept_ids_flat must be a comma separated list of parent "
+                f"concept names. Received: {self.parent_concept_ids_flat}"
+            )
+        return self
+
+
 class Filters(BaseModel):
     """Filterable fields in a search request"""
 
@@ -171,6 +234,11 @@ class SearchParameters(BaseModel):
     E.g. [{"name": "family.sector", "value": "Price"}]
     """
 
+    concept_filters: Optional[Sequence[ConceptFilter]] = None
+    """
+    A field and item mapping to search in the concepts field of the document passages.
+    """
+
     @model_validator(mode="after")
     def validate(self):
         """Validate against mutually exclusive fields"""
@@ -291,6 +359,7 @@ class Hit(BaseModel):
     corpus_type_name: Optional[str] = None
     corpus_import_id: Optional[str] = None
     metadata: Optional[Sequence[dict[str, str]]] = None
+    concepts: Optional[Sequence[Concept]] = None
 
     @classmethod
     def from_vespa_response(cls, response_hit: dict) -> "Hit":
@@ -354,6 +423,7 @@ def from_vespa_response(cls, response_hit: dict) -> "Document":
             corpus_type_name=fields.get("corpus_type_name"),
             corpus_import_id=fields.get("corpus_import_id"),
             metadata=fields.get("metadata"),
+            concepts=fields.get("concepts"),
         )
 
 
@@ -381,6 +451,7 @@ def from_vespa_response(cls, response_hit: dict) -> "Passage":
             if family_publication_ts
             else None
         )
+
         return cls(
             family_name=fields.get("family_name"),
             family_description=fields.get("family_description"),
@@ -405,6 +476,7 @@ def from_vespa_response(cls, response_hit: dict) -> "Passage":
             text_block_page=fields.get("text_block_page"),
             text_block_coords=fields.get("text_block_coords"),
             metadata=fields.get("metadata"),
+            concepts=fields.get("concepts"),
         )
 
 

src/cpr_sdk/version.py

@@ -1,6 +1,6 @@
 _MAJOR = "1"
 _MINOR = "8"
-_PATCH = "0"
+_PATCH = "1"
 _SUFFIX = ""
 
 VERSION_SHORT = "{0}.{1}".format(_MAJOR, _MINOR)

src/cpr_sdk/yql_builder.py

@@ -104,6 +104,18 @@ def build_metadata_filter(self) -> Optional[str]:
             return f"({' and '.join(metadata_filters)})"
         return None
 
+    def build_concepts_filter(self) -> Optional[str]:
+        """Create the part of the query that limits to specific concepts"""
+        if self.params.concept_filters:
+            concepts_query = []
+            for concept in self.params.concept_filters:
+                if concept.name == "parent_concept_ids_flat":
+                    concepts_query.append(f"{concept.name} matches '{concept.value}'")
+                else:
+                    concepts_query.append(f"{concept.name} contains '{concept.value}'")
+            return f"(concepts contains sameElement({', '.join(concepts_query)}))"
+        return None
+
     def build_corpus_type_name_filter(self) -> Optional[str]:
         """Create the part of the query that limits to specific corpora"""
         if self.params.corpus_type_names:
@@ -163,6 +175,7 @@ def build_where_clause(self) -> str:
         filters.append(self.build_corpus_type_name_filter())
         filters.append(self.build_corpus_import_ids_filter())
         filters.append(self.build_metadata_filter())
+        filters.append(self.build_concepts_filter())
         if f := self.params.filters:
             filters.append(self._inclusive_filters(f, "family_geographies"))
             filters.append(self._inclusive_filters(f, "family_geography"))

tests/conftest.py

@@ -1,14 +1,13 @@
 import json
-from pathlib import Path
 import tempfile
+from pathlib import Path
 
-import pytest
 import boto3
+import pytest
 from moto import mock_aws
 
 from cpr_sdk.search_adaptors import VespaSearchAdapter
 
-
 VESPA_TEST_SEARCH_URL = "http://localhost:8080"
 
 

tests/local_vespa/test_app/schemas/document_passage.sd

@@ -44,6 +44,42 @@ schema document_passage {
                 }
             }
         }
+
+        struct parent_concept {
+            field id type string {}
+            field name type string {}
+        }
+
+        struct concept {
+            field name                       type string {}
+            field id                         type string {}
+            field parent_concepts            type array<parent_concept> {}
+            field parent_concept_ids_flat    type string {}
+            field start                      type int {}
+            field end                        type int {}
+            field model                      type string {}
+            field timestamp                  type string {}
+        }
+
+        field concepts type array<concept> {
+            indexing: summary
+
+            struct-field name {
+                indexing: attribute
+            }
+            struct-field id {
+                indexing: attribute
+            }
+            struct-field parent_concept_ids_flat {
+                indexing: attribute
+            }
+            struct-field model {
+                indexing: attribute
+            }
+            struct-field timestamp {
+                indexing: attribute
+            }
+        }
     }
 
     import field family_document_ref.family_name as family_name {}
@@ -95,6 +131,7 @@ schema document_passage {
         summary text_block_type {}
         summary text_block_page {}
         summary text_block_coords {}
+        summary concepts {}
     }
 
     rank-profile exact inherits default {