Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip version check for Dependabot #55

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented Jul 22, 2024

Description

This will always fail on Dependabot PRs, since it doesn't increment the version, and thus will always be equal to, or behind, the latest GitHub release.

This means that we can merge Dependabot PRs in, and for them to be released, we'd need to do a release.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail (integrated soon)
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Let CI run.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

Copy link

linear bot commented Jul 22, 2024

@jesse-c jesse-c force-pushed the feature/pods-1184-enable-sdk-dependabot branch from 684af7f to 69aba99 Compare July 22, 2024 14:51
@jesse-c jesse-c marked this pull request as ready for review July 22, 2024 14:51
@jesse-c jesse-c requested a review from a team as a code owner July 22, 2024 14:51
@jesse-c jesse-c force-pushed the feature/pods-1184-enable-sdk-dependabot branch from 69aba99 to 50c84a3 Compare July 22, 2024 15:23
This will always fail on Dependabot PRs, since it doesn't increment
the version, and thus will always be equal to, or behind, the latest
GitHub release.

This means that we can merge Dependabot PRs in, and for them to be
released, we'd need to do a release.
@jesse-c jesse-c force-pushed the feature/pods-1184-enable-sdk-dependabot branch from 50c84a3 to 4057275 Compare July 22, 2024 15:29
Copy link
Collaborator

@THOR300 THOR300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As discussed we are manually releasing and check the package versions match before we actually publish to pypi so we're happy with this solution rather than trying to get dependabot pr's to update the package version in the pr.

@jesse-c jesse-c merged commit b1fdf7d into main Jul 22, 2024
6 checks passed
@jesse-c jesse-c deleted the feature/pods-1184-enable-sdk-dependabot branch July 22, 2024 15:42
jesse-c added a commit that referenced this pull request Jul 22, 2024
An oversight from #55, as it meant that tests weren't being run.
jesse-c added a commit that referenced this pull request Jul 22, 2024
An oversight from #55, as it meant that tests weren't being run.
jesse-c added a commit that referenced this pull request Jul 22, 2024
An oversight from #55, as it meant that tests weren't being run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants