Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and naming improvements. #9

Conversation

THOR300
Copy link
Collaborator

@THOR300 THOR300 commented Apr 22, 2024

Description

  • Naming improvements in some of the ci files.
  • There are then some refactoring changes due to trunk now running in the vscode window.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

The changes will be tested by the test publish flow in CI and the new test that checks that the placeholder is 0.0.0.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@THOR300 THOR300 changed the title Updating the placeholder and adding a comment to make it clear that i… Placeholder bugfix Apr 22, 2024
@THOR300 THOR300 changed the title Placeholder bugfix Update the placeholder in the pyproject.toml and add comments along with other naming improvements. Apr 22, 2024
@THOR300 THOR300 requested review from katybaulch and kdutia April 22, 2024 13:44
@kdutia
Copy link
Member

kdutia commented Apr 23, 2024

sorry, i don't think i understand this change enough to review it!

@THOR300 THOR300 changed the title Update the placeholder in the pyproject.toml and add comments along with other naming improvements. Resolve package version mismatch Apr 25, 2024
@THOR300 THOR300 changed the base branch from main to bugfix/enforce-placeholder-version April 25, 2024 08:16
@THOR300 THOR300 changed the title Resolve package version mismatch Refactoring and naming improvements. Apr 25, 2024
@THOR300 THOR300 closed this Apr 25, 2024
@THOR300 THOR300 deleted the bugfix/correct-pyproject-version branch April 25, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants