Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/app 208 bulk import updates 2 #296

Merged
merged 37 commits into from
Feb 25, 2025

Conversation

annaCPR
Copy link
Contributor

@annaCPR annaCPR commented Feb 20, 2025

Description

  • add ability to do a bulk update
  • only update data when there are changes
  • remove some unnecessary logs/prints
  • update some exisiting tests
  • add corpus import id validation to the bulk import router
  • add localstack to docker-compose-dev.yml to allow for local testing of bulk import

Please include:

  • a summary of the changes
  • links to any related issue/ticket
  • any additional relevant motivation and context
  • details of any dependency updates that are required for this change

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Remove legacy code
  • Dependency update

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small drive-by fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

annaCPR and others added 30 commits February 13, 2025 11:10
The log info will not be captured, we also already have a similar log i nthe service and the user is always the same
Copy link

linear bot commented Feb 20, 2025

@annaCPR annaCPR marked this pull request as ready for review February 20, 2025 12:27
@annaCPR annaCPR requested a review from a team as a code owner February 20, 2025 12:27
Copy link
Contributor

@odrakes-cpr odrakes-cpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@annaCPR annaCPR merged commit fe18b2c into main Feb 25, 2025
10 checks passed
@annaCPR annaCPR deleted the feature/app-208-bulk-import-updates-2 branch February 25, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants