Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in slug updates. #69

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Adding in slug updates. #69

merged 4 commits into from
Nov 20, 2023

Conversation

THOR300
Copy link
Collaborator

@THOR300 THOR300 commented Nov 16, 2023 •
edited
Loading

This Pull Request:

  • Integrates functionality to update the document slug as well during name updates.

TODO: Proper semver tagging of dal.

@linear Linear
Copy link

linear bot commented Nov 16, 2023

PDCT-589 Bugfix for the mismatching slug

Also update the slug as well when we have name changes in the BackendDocument objects.

This is as slug changes when the document name changes.

How will we test this?

  • Write a bugfix in the ingest / identify updates stages.
  • Write this into the pipeline integration tests. I.e. a slug mismatch and verify that we would update such an issue.
  • Run a pipeline ingest in staging, verify that this document in question has changed and doesn't receive the issue in search.

@THOR300 THOR300 requested a review from olaughter November 17, 2023 21:07
@THOR300 THOR300 mentioned this pull request Nov 19, 2023
Merged
olaughter
olaughter approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@olaughter olaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of code suggestions below

src/navigator_data_ingest/base/updated_document_actions.py Show resolved Hide resolved
src/navigator_data_ingest/base/updated_document_actions.py Outdated Show resolved Hide resolved
src/navigator_data_ingest/base/updated_document_actions.py Outdated Show resolved Hide resolved
src/navigator_data_ingest/base/updated_document_actions.py Outdated Show resolved Hide resolved
@THOR300 THOR300 merged commit 126ab82 into main Nov 20, 2023
3 checks passed
@THOR300 THOR300 deleted the feature/pdct-589-bugfix-for-the-mismatching-slug branch November 20, 2023 11:59
THOR300 added a commit that referenced this pull request Nov 21, 2023
@THOR300
Refactor/sort out dependencies (#70)
3995341 
This Pull Request: 
---
- Integrates refactoring changes to clean up the dependencies and
workflow files in the repo
- This branch is pulled from the following branch / PR:
#69
- Updated method of pulling documents from s3.

---------

Co-authored-by: Mark <mark@climatepolicyradar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olaughter olaughter olaughter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@THOR300 @olaughter