Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in the ingest stage for pydantic errors on document source url. #71

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

THOR300
Copy link
Collaborator

@THOR300 THOR300 commented Dec 13, 2023

This Pull Request:

  • Integrates a bug fix for catching pydantic validation errors in the ingest stage.
  • The function expects a ParserInput object in the response even on failure and thus constructing this without a document source url if validation fails.
  • Couldn't just move the try and except because of this.
  • I don't think we need to catch validation errors on the instantiation of the ParserInput object if the document source url passes as everything else is a direct type copy. E.g. import id [str] -> document import id [str]

Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🍠

Copy link
Contributor

@olaughter olaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thoughts are minor, around making it easier for ourselves when we come back to this. One comment on that below, and also wondering if a more descriptive PR title would make it easier for future us?

@THOR300 THOR300 changed the title Debugging. Bugfix in the ingest stage for pydantic errors on document source url. Dec 13, 2023
@THOR300 THOR300 merged commit 990a357 into main Dec 13, 2023
2 checks passed
@THOR300 THOR300 deleted the bugfix/catch-pydantic-errors branch December 13, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants