Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-223 Bump tailwind major version #364

Merged
merged 48 commits into from
Feb 20, 2025

Conversation

PatFawbertMills
Copy link
Contributor

@PatFawbertMills PatFawbertMills commented Feb 18, 2025

What's changed

  • Tailwind major breaking change upgrade from v3 -> v4
  • Lots of small UI fixes along the way
  • Removal of all old theme configuration
  • Migration over to .css files
  • Removal of all scss
  • Housekeeping of some smaller components as drive-bys

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Copy link

linear bot commented Feb 18, 2025

Copy link

github-actions bot commented Feb 18, 2025

size-limit report 📦

Path Size
Next static files 307.68 KB (-0.23% 🔽)

@PatFawbertMills PatFawbertMills marked this pull request as ready for review February 18, 2025 11:36
@PatFawbertMills PatFawbertMills requested a review from a team as a code owner February 18, 2025 11:36
Copy link
Contributor

@jesskelsall jesskelsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the whole looks solid. I've spot checked some of the places where Tailwind is used and am happy. I have a few queries about some of the specifics of the stylesheets which I'd like addressing before I approve.

Copy link
Contributor

@jesskelsall jesskelsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after my comments were addressed and with pragmatic considerations for getting this working for now. We'll continue to improve our Tailwind usage as new components are built.

@PatFawbertMills PatFawbertMills merged commit 4fa1b96 into main Feb 20, 2025
20 checks passed
@PatFawbertMills PatFawbertMills deleted the feature/APP-223-bump-tailwind-major-version branch February 20, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants