Added async event stream map fixes #11 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, this is something I did start but have gotten super busy to finish implementing! I'll take a look later today and add this. I'll have to bump the major version and update some docs and things, too, in addition to your changes here. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
...but I've been able to make this plugin asynchronous.
I took a look at some other gulp-plugins and came across https://www.npmjs.com/package/event-stream which has an async
mapfunction https://www.npmjs.com/package/event-stream#map-asyncfunctionI've dropped the dependency on
through2and replaced it withevent-streamand now all the files in the stream are processed asynchronously. 🎉