Handle headObject 403 response when ListBucket permission is missing #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically if an object doesn't exist then S3 headObject returns 404 or 403 depending on whether you have s3:ListBucket permission.
|
@clineamb Can you have a look whether this PR makes sense to you? Basically it handles an error code from S3 when ListBucket permission is missing (upload is still possible in this case). |
|
Ah, sorry, life has been busy for me, so I haven't had a chance to take a look at this yet! I will before the week is out! thanks so much for this PR |
|
Found some time just now! Thanks so much for this quick addition! (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically if an object doesn't exist then S3 headObject returns 404 or 403 depending on whether you have s3:ListBucket permission.