Log when upload is skipped and invoke callback #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clineamb when you get a chance it'd be great if you could take a look at this PR. or any other maintainer of this Repo. Thanks! |
|
This change looks good - sorry it took so long to get eyes on until now. Will merge later today when I get to a computer! |
|
@clineamb Thanks! |
clineamb
added a commit
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file differs from the one on S3 and
uploadNewFilesOnlyis set totrue, there is no informative console message andcallbackis never called, resulting in gulp erroring with "The following tasks did not complete: ... Did you forget to signal async completion?"