Don't mutate the options object between files #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lead to a bug where the result of metadata map for the first file would result be applied to all subsequent files
|
Whoop! Gotcha. Thanks for the update. (: |
clineamb
added a commit
that referenced
this pull request
Mar 10, 2015
Don't mutate the options object between files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's a bug in
metadataMap- the metadataMap from the first file would be applied to app subsequent file. This is because the oneoptionsobject is shared across all files, and then is mutated.The
if(!options.Metadata && options.metadataMap){}block will not be ran ifoptions.Metadataexists, and then within that block,optionsis mutated to addoptions.Metadata, preventing it from updating for subsequent files. I fixed this my saving metadata into a new locally scopedmetadatavariable, and then saving that later intoobjOpts.Metadata.