Detect module name for eval frames #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanSl
approved these changes
Mar 15, 2019
admataz
pushed a commit
that referenced
this pull request
Mar 28, 2019
* Add failing test for #303 * Detect module name for eval frames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303, where the topmost frame in a stack for an external module was part of an eval() call. When marking aggregate nodes it tried to get the module name of the topmost frame in the module, which would be
nullfor eval frames.eval frames contain a file path in brackets
eval at parentFn (/path.js:X:Y)inside theevalOriginproperty, so we can fall back to that.