Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporating metrics from the threadpool #58

Open
davisjam opened this issue Sep 19, 2018 · 1 comment
Open

Incorporating metrics from the threadpool #58

davisjam opened this issue Sep 19, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@davisjam
Copy link
Contributor

This is a feature request, not a bug report. It is not currently actionable.

node-clinic currently gives great insight into the event loop. For some applications this is sufficient. For others, understanding the state of the threadpool may be crucial to tuning the threadpool size or the application behavior for best performance.

The threadpool has historically been hidden in libuv without a monitoring API (but see libuv #1528). I am trying to change this. I have proposed a libuv PR to make the libuv threadpool pluggable (libuv #1726) and a corresponding Node.js PR proposing various Node-land threadpools (Node.js #22631).

I would love to see threadpool monitoring integrated into node-clinic's offerings. To that end, I'd like to understand what kind of API and metrics you think would be beneficial. Please chime in on Node.js #22957 if you have thoughts.

@jasnell
Copy link
Contributor

jasnell commented Sep 19, 2018

See libuv/libuv#1815 :-)

Currently it is blocked by (a) @bnoordhuis and (b) some rebasing and updating that I need to do.

@DylanC DylanC added the enhancement New feature or request label Feb 19, 2020
jasnell added a commit to jasnell/node-clinic that referenced this issue Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants