Skip to content

Commit

Permalink
chore: Makefile and dockerfile cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
clintjedwards committed Sep 18, 2023
1 parent 1365196 commit 619e186
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 48 deletions.
1 change: 1 addition & 0 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ Also github integration:
- Extensions should follow semver. Extensions that use the same major version of Gofer should be compatible.
- If a extension by the same name is already installed, we should refuse to install another but instead allow the user to update it.
- Extensions should be able to report details about their execution somehow. It would be nice when looking at my pipeline run to see exactly when the extension performed certain actions. And be able to troubleshoot an extension that is taking overly long.
- Make sure to put in the extension documentation which versions are compatible with gofer. The current scheme is that all major versions are compatible with all same major versions. So if Gofer releases a 1.0, then all extensions will have to release a 1.0. This means that extensions can update their minor and patch versioning, but major versions will also be compatible with the same Gofer major version. Make sure this is documented.

#### More extensions:

Expand Down
47 changes: 0 additions & 47 deletions containers/Makefile

This file was deleted.

2 changes: 1 addition & 1 deletion containers/extensions/github/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19 AS build-environment
FROM golang:1.20 AS build-environment

LABEL org.opencontainers.image.source https://github.com/clintjedwards/gofer

Expand Down

0 comments on commit 619e186

Please sign in to comment.