Continuous integration - jshint & jscs #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Casey,
this is a little follow up to my ATP feedback from yesterday (about the importance of automatic codestyle checking with continuous integration). I configured the jshint and jscs tools to check Camel source code. I hope I chose sensible settings -- I tried to stick to the current style of your code assuming this is what you want it to look like. I only fixed a few warnings produced by jshint that (I assume) will result in safer code.
I also added Travis CI configuration. It automatically runs the checks on every push and on every pull request. If you will make use of this pull request, you should sign in at travis-ci.org and configure the automatic builds. The result will look like this (builds of my fork this pull request is from). The badge in README will appear once you configure the build.
If you add tests to Camel one day, you can run them in Travis as well.