Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow charging schedule configuration #37

Merged
merged 3 commits into from
May 20, 2024
Merged

Allow charging schedule configuration #37

merged 3 commits into from
May 20, 2024

Conversation

nanomad
Copy link
Contributor

@nanomad nanomad commented Apr 15, 2024 •
edited
Loading

Fixes #38

@nanomad nanomad mentioned this pull request Apr 15, 2024
Merged
cliviu74
cliviu74 requested changes May 15, 2024
View reviewed changes
Copy link
Owner

@cliviu74 cliviu74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please document getChargerSchedules and setChargerSchedules methods in the main README.md?

wallbox/wallbox.py Outdated Show resolved Hide resolved
@cliviu74
Copy link
Owner

Can you please add documentation for setChargerSchedules and getChargerSchedules to the main README.md

@nanomad nanomad requested a review from cliviu74 May 20, 2024 09:33
@nanomad
Copy link
Contributor Author

nanomad commented May 20, 2024

@cliviu74 done :)

@cliviu74
Copy link
Owner

Nice one, thanks a million @nanomad

@cliviu74 cliviu74 merged commit 60b18cf into cliviu74:master May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliviu74 cliviu74 Awaiting requested review from cliviu74

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for reading and writing charging schedules
2 participants
@nanomad @cliviu74