Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout to put/post methods #51

Merged
merged 1 commit into from
May 20, 2024
Merged

add timeout to put/post methods #51

merged 1 commit into from
May 20, 2024

Conversation

cliviu74
Copy link
Owner

Fix for #49

  • add timeout to post/put requests
  • minor code formatting

@tmenguy
Copy link

tmenguy commented May 20, 2024

great, the only issue I has with this is the variable name : it is called GetTimeout .... and we use it everywhere, I preferred th let it as it is to no break any compatibility. Anyway great to have the fix, hope you can merge it soon so we can merge the #46 right after

@cliviu74 cliviu74 merged commit 7f81aac into master May 20, 2024
@cliviu74
Copy link
Owner Author

Agreed with the *getTimeout, should be more general.
I'll think about a refactor, pending finding some time.

@cliviu74 cliviu74 deleted the bugfix/request-timeout branch May 22, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants