Fix normalize-and-pad-markup to skip actually padding
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlship
reviewed
Jan 22, 2025
| @@ -196,11 +196,11 @@ | |||
| ;; If at or over desired width, don't need to pad | |||
| (if (<= width actual-width) | |||
| {:width actual-width | |||
There was a problem hiding this comment.
TODO: Hook up clj-kondo to find this kind of thing.
hlship
approved these changes
Jan 22, 2025
hlship
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up reading through the ANSI namespace while tracking down a red herring, and stumbled on this
ifform. The call toapply-paddingwasn't changing the data, but it would incur some amount of processing overhead that we don't need to do.Thanks for considering, and let me know if there's anything I need to adjust/modify.