-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coveralls badge to README #53
Conversation
I’m a bit disappointed by the whole coverage thing: it does not include doc-tests (would need the nightly compiler and it’s unstable taiki-e/cargo-llvm-cov#2) nor the integration tests (because they are in a separate binary I suspect). In its current state, it’s a bit misleading. I’m thinking of showing coverage only for the code that’s not behind features and to move back the integration tests that don’t need features in the standard directory. |
cc @czocher |
It does not run the doctests, but from what I see it does run the integration tests:
We can use the nigthly unstable feature for the doctest support since it does not influence the project, just the CI, which we do not guarantee anything about. What do you think @cljoly? |
You are right I looked too quickly, integration tests are run indeed. And we can give a try to the nightly CI builds, if it turn out to be too unstable (i.e. if it fails on valid code too often), we can always go back to stable. |
Hum, so with nightly / the doctest option, coveralls does not get the sources: https://coveralls.io/builds/57998356/source?filename=rusqlite_migration%2Fsrc%2Fasynch.rs. That’s annoying. I guess if I have to chose, I prefer to have a slightly lower coverage but an easy access to uncovered lines for contributors who may not want to go through all the trouble of installing cargo-llvm-cov and running it locally. |
Maybe codecov.io would work better on this, but they seem very confused by the fact that I renamed this repo years ago. |
2f57b5d
to
0ddf90a
Compare
@cljoly what's the story with If it supports them we can migrate easily. |
Yes, that’s a good point, perhaps it won’t be too slow and it’ll work better with the doc-tests. Could you please try to migrate to tarpaulin, if you have time? |
@cljoly sure, I'll implement it later today. |
Great thank you. |
0ddf90a
to
56151e6
Compare
No description provided.