Update message instead of resend #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdiel
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Overall love the approach. Left a few quick observations. I'll pull it down and test on mine too in a bit and then I can approve.
Take a look at #11, I left a question that will dictate which order you'll want to merge these
adamdiel
approved these changes
Aug 16, 2024
|
Closes #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamdiel Take a look!
This PR prevents the creation of a new message for every song, by editing the previous embed: 356ffc3
It also reworks the stop function to be a bit less redundant and to give more user feedback: ea88c53 7aaebbf
Finally it changes
updatePlaying()tocancelinstead ofstop. d464b9a