Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress bar #28

Merged
merged 16 commits into from
Aug 20, 2024
Merged

Add progress bar #28

merged 16 commits into from
Aug 20, 2024

Conversation

clockwinder
Copy link
Owner

Adds progress bar and timer, pulls their configuration from the config file.

@clockwinder
Copy link
Owner Author

@adamdiel Are you willing to take this one for a test spin before I merge it?

adamdiel
adamdiel approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@adamdiel adamdiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only manual things I had to do to get this to work was

  • Update my config file to have the params added for the status bar
  • Update my rainwave python library ( Be good to add a requirements.txt )
  • Add my opus code to get it working on my machine

@clockwinder
Copy link
Owner Author

All issues are addressed by:
#29
#19

@clockwinder clockwinder merged commit a745f08 into main Aug 20, 2024
@clockwinder clockwinder deleted the add_progress_bar branch August 20, 2024 17:19
@clockwinder clockwinder mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdiel adamdiel adamdiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clockwinder @adamdiel